Skip to content

Less strict numpy and pyarrow dependencies #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Less strict numpy and pyarrow dependencies #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b57d4ea
Less strict dependencies
Tom-Newton Dec 15, 2022
f48ad07
Fix python version condition
Tom-Newton Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ python = "^3.7.1"
thrift = "^0.16.0"
pandas = "^1.3.0"
pyarrow = [
{version = ">=9.0.0", python = ">=3.7,<3.11"},
{version = ">=6.0.0", python = ">=3.7,<3.11"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we could allow even older versions but I think this should make most people happy.

{version = ">=10.0.1", python = ">=3.11"}
]
lz4 = "^4.0.2"
requests="^2.18.1"
oauthlib="^3.1.0"
numpy = [
{version = "1.21.1", python = ">=3.7,<3.8"},
{version = "1.23.4", python = ">=3.8"}
{version = ">=1.16.6", python = ">=3.7,<3.11"},
{version = ">=1.23.4", python = ">=3.11"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the special requirement for python 3.11 was added recently in #60 so I assume that is important but I changed it to accept >= to this version.

I also think we should only enforce this requirement on python 3.11

]

[tool.poetry.dev-dependencies]
Expand Down