Skip to content

New Complex type test table + Github Action changes #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .github/workflows/code-quality-checks.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
name: Code Quality Checks
on:
push:
branches:
- main
- sea-migration
- telemetry
pull_request:
branches:
- main
- sea-migration
- telemetry

on: [pull_request]

jobs:
run-unit-tests:
runs-on: ubuntu-latest
Expand Down
10 changes: 3 additions & 7 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
name: Integration Tests

on:
push:
paths-ignore:
- "**.MD"
- "**.md"
pull_request:
push:
branches:
- main
- sea-migration
- telemetry
pull_request:

jobs:
run-e2e-tests:
Expand Down
10 changes: 5 additions & 5 deletions tests/e2e/test_complex_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def table_fixture(self, connection_details):
# Create the table
cursor.execute(
"""
CREATE TABLE IF NOT EXISTS pysql_test_complex_types_table (
CREATE TABLE IF NOT EXISTS pysql_e2e_test_complex_types_table (
array_col ARRAY<STRING>,
map_col MAP<STRING, INTEGER>,
struct_col STRUCT<field1: STRING, field2: INTEGER>
Expand All @@ -24,7 +24,7 @@ def table_fixture(self, connection_details):
# Insert a record
cursor.execute(
"""
INSERT INTO pysql_test_complex_types_table
INSERT INTO pysql_e2e_test_complex_types_table
VALUES (
ARRAY('a', 'b', 'c'),
MAP('a', 1, 'b', 2, 'c', 3),
Expand All @@ -34,7 +34,7 @@ def table_fixture(self, connection_details):
)
yield
# Clean up the table after the test
cursor.execute("DROP TABLE IF EXISTS pysql_test_complex_types_table")
cursor.execute("DROP TABLE IF EXISTS pysql_e2e_test_complex_types_table")

@pytest.mark.parametrize(
"field,expected_type",
Expand All @@ -45,7 +45,7 @@ def test_read_complex_types_as_arrow(self, field, expected_type, table_fixture):

with self.cursor() as cursor:
result = cursor.execute(
"SELECT * FROM pysql_test_complex_types_table LIMIT 1"
"SELECT * FROM pysql_e2e_test_complex_types_table LIMIT 1"
).fetchone()

assert isinstance(result[field], expected_type)
Expand All @@ -57,7 +57,7 @@ def test_read_complex_types_as_string(self, field, table_fixture):
extra_params={"_use_arrow_native_complex_types": False}
) as cursor:
result = cursor.execute(
"SELECT * FROM pysql_test_complex_types_table LIMIT 1"
"SELECT * FROM pysql_e2e_test_complex_types_table LIMIT 1"
).fetchone()

assert isinstance(result[field], str)
Loading