Skip to content

convert column table to arrow if arrow present #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/databricks/sql/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1415,9 +1415,22 @@ def fetchall_arrow(self) -> "pyarrow.Table":
while not self.has_been_closed_server_side and self.has_more_rows:
self._fill_results_buffer()
partial_results = self.results.remaining_rows()
results = pyarrow.concat_tables([results, partial_results])
if isinstance(results, ColumnTable) and isinstance(
partial_results, ColumnTable
):
results = self.merge_columnar(results, partial_results)
else:
results = pyarrow.concat_tables([results, partial_results])
self._next_row_index += partial_results.num_rows

# If PyArrow is installed and we have a ColumnTable result,
# convert it to a PyArrow Table for consistency with pre-3.5.0 behavior
if isinstance(results, ColumnTable) and pyarrow:
data = {
name: col
for name, col in zip(results.column_names, results.column_table)
}
return pyarrow.Table.from_pydict(data)
return results

def fetchall_columnar(self):
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/test_driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,13 @@ def test_decimal_not_returned_as_strings_arrow(self):
decimal_type = arrow_df.field(0).type
assert pyarrow.types.is_decimal(decimal_type)

@skipUnless(pysql_supports_arrow(), "arrow test needs arrow support")
def test_catalogs_returns_arrow_table(self):
with self.cursor() as cursor:
cursor.catalogs()
results = cursor.fetchall_arrow()
assert isinstance(results, pyarrow.Table)

def test_close_connection_closes_cursors(self):

from databricks.sql.thrift_api.TCLIService import ttypes
Expand Down
Loading