Skip to content

Added urllib3 version check #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Added urllib3 version check #547

merged 2 commits into from
Apr 21, 2025

Conversation

jprakash-db
Copy link
Contributor

@jprakash-db jprakash-db commented Apr 17, 2025 •
edited
Loading

Description

urllib3<2.x and urllib3>=2.x have a difference of the presence of the backoff_jitter value in the Inherited Retry class. Added checks to ensure that customers can use urllib3<2.x and urllib3>=2.x versions of the library with the databricks-sql-connector

@jprakash-db jprakash-db requested a review from shivam2680 April 17, 2025 09:54
@jprakash-db jprakash-db self-assigned this Apr 17, 2025
@github-actions GitHub Actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions GitHub Actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@jackyhu-db
Copy link
Collaborator

can you explain the motivation for this change in the description?

@jprakash-db
Copy link
Contributor Author

@jackyhu-db Updated the description

@jprakash-db jprakash-db merged commit 6206df4 into main Apr 21, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyhu-db jackyhu-db jackyhu-db approved these changes

@shivam2680 shivam2680 shivam2680 approved these changes

@deeksha-db deeksha-db Awaiting requested review from deeksha-db deeksha-db is a code owner

@samikshya-db samikshya-db Awaiting requested review from samikshya-db samikshya-db is a code owner

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@benc-db benc-db Awaiting requested review from benc-db benc-db is a code owner

Assignees

@jprakash-db jprakash-db

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jprakash-db @jackyhu-db @shivam2680