Skip to content

Adds packaging python package to requirements #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

madhav-db
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

We use the packaging module in the retry logic in retry.py. This PR adds the packaging module as a requirement for this usecase.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Manual poetry installation and venv installation

Related Tickets & Documents

#540

Copy link

github-actions bot commented Apr 8, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

github-actions bot commented Apr 8, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@jprakash-db
Copy link
Contributor

packaging is not on the dependency list in 4.0.0, is there an RCA on how it was working before? Because no changes to the pyproject.toml was made related to this. This seems to be a very recent issue

@madhav-db
Copy link
Contributor Author

Closing the PR since the offending line has been removed and will not be required in the upcoming release.

@madhav-db madhav-db closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants