Skip to content

[ES-1372353] make user_agent_header part of public API #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 12, 2025
Merged

[ES-1372353] make user_agent_header part of public API #530

merged 5 commits into from
Mar 12, 2025

Conversation

shivam2680
Copy link
Contributor

Description

  • Renamed _user_agent_entry in connect call args to user_agent_entry.
  • removed this from list of internal arguments in docstring.

How is this tested?

Verified agent population in query history when using user_agent_entry

Related Tickets & Documents

ES-1372353

@shivam2680 shivam2680 requested a review from deeksha-db as a code owner March 10, 2025 07:03
jprakash-db
jprakash-db approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@jprakash-db jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. LGTM

@shivam2680 shivam2680 requested a review from samikshya-db March 12, 2025 04:18
@shivam2680 shivam2680 merged commit 403d69f into main Mar 12, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprakash-db jprakash-db jprakash-db approved these changes

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db

@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db jackyhu-db is a code owner

@benc-db benc-db Awaiting requested review from benc-db benc-db is a code owner

@deeksha-db deeksha-db Awaiting requested review from deeksha-db deeksha-db is a code owner

@samikshya-db samikshya-db Awaiting requested review from samikshya-db samikshya-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivam2680 @samikshya-db @jprakash-db