Add version check for urllib3 in backoff calculation #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam2680
requested review from
rcypher-databricks,
yunbodeng-db,
andrefurlan-db,
jackyhu-db and
benc-db
as code owners
benc-db
approved these changes
Mar 5, 2025
|
pwease merge this soon :) |
samikshya-db
approved these changes
Mar 10, 2025
|
Thanks for fixing this, @shivam2680 ! |
wyattscarpenter
pushed a commit
to wyattscarpenter/databricks-sql-python
that referenced
this pull request
Mar 11, 2025
Signed-off-by: Shivam Raj <[email protected]> Signed-off-by: wyattscarpenter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #525
Added version check for
urllib3to apply additional backoff jitter if version is>=2.0.0.How is this tested?
Tested manually using the connector to trigger retry flow.