Fix : Unable to poll results in async API #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprakash-db
requested review from
rcypher-databricks,
yunbodeng-db,
andrefurlan-db,
jackyhu-db and
benc-db
as code owners
src/databricks/sql/thrift_backend.py
Outdated
| getDirectResults=ttypes.TSparkGetDirectResults( | ||
| maxRows=max_rows, maxBytes=max_bytes | ||
| maxRows=0 if async_op else max_rows, |
There was a problem hiding this comment.
Instead of setting maxRows as 0, I would recommend not specifying the direct result object in the request altogether. This is to make the intention clear of not expecting the direct results.
There was a problem hiding this comment.
Have made the object None
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Comment on lines
+902
to
907
| getDirectResults=None | ||
| if async_op | ||
| else ttypes.TSparkGetDirectResults( | ||
| maxRows=max_rows, | ||
| maxBytes=max_bytes, | ||
| ), |
There was a problem hiding this comment.
do we have a linter for python driver yet? if not, could you please open an issue to community or internally?
There was a problem hiding this comment.
@jayantsing-db I can raise a new PR for that
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
jprakash-db
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
| @@ -94,7 +94,7 @@ def test_long_running_query(self): | |||
| scale_factor = 1 | |||
| with self.cursor() as cursor: | |||
| while duration < min_duration: | |||
| assert scale_factor < 512, "Detected infinite loop" | |||
| assert scale_factor < 1024, "Detected infinite loop" | |||
There was a problem hiding this comment.
For long running queries the previous upper limit of scale factor was not sufficient to run queries for atleast 5 minutes, hence increased it
samikshya-db
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polling using the async API returned the
RESOURCE_NOT_FOUNDerror for async executed queriesFix
Force retention of data on the server side by not returning the results in the
direct resultswithin theexecute_queryresponseTesting
Added e2e tests