Skip to content

Added info logging for response #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 23, 2025
Merged

Added info logging for response #511

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a559ee
Added some logging support
jprakash-db Feb 19, 2025
9944f78
Logs are based on what the server returns
jprakash-db Feb 20, 2025
9ffaee4
Added back some of the better errors
jprakash-db Feb 21, 2025
547d55b
Print status if not detected as error
jprakash-db Feb 21, 2025
f305198
Added logging in the flush step
jprakash-db Feb 22, 2025
c4aad86
Reformatted
jprakash-db Feb 22, 2025
17838ee
Removed some unnecessary
jprakash-db Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/databricks/sql/auth/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,8 @@ def should_retry(self, method: str, status_code: int) -> Tuple[bool, str]:
if a retry would violate the configured policy.
"""

logger.info(f"Received status code {status_code} for {method} request")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get 4xx or 5xx, do we only get a status code, or do we also get an error message of some sort?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benc-db I have updated such that the error messages from the server are printed and not our custom messages


# Request succeeded. Don't retry.
if status_code == 200:
return False, "200 codes are not retried"
Expand Down
Loading