Skip to content

Incorrect rows in inline fetch result #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 22, 2024
Merged

Incorrect rows in inline fetch result #479

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2785d0a
Raised error when incorrect Row offset it returned
jprakash-db Dec 11, 2024
1f3bc19
Changed error type
jprakash-db Dec 12, 2024
8d20b79
grammar fix
jprakash-db Dec 12, 2024
887a9e0
Added unit tests and modified the code
jprakash-db Dec 15, 2024
bf26881
Updated error message
jprakash-db Dec 16, 2024
b2202c7
Updated the non retying to only inline case
jprakash-db Dec 17, 2024
8e759db
Updated fix
jprakash-db Dec 19, 2024
1ac441a
Changed the flow
jprakash-db Dec 19, 2024
fba9759
Minor update
jprakash-db Dec 19, 2024
aefd44b
Updated the retryable condition
jprakash-db Dec 20, 2024
ea686c7
Minor test fix
jprakash-db Dec 20, 2024
e6e573c
Added extra space
jprakash-db Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/databricks/sql/thrift_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,7 +1046,7 @@ def fetch_results(

resp = self.make_request(self._client.FetchResults, req)
if resp.results.startRowOffset > expected_row_start_offset:
logger.warning(
raise ValueError(
"Expected results to start from {} but they instead start at {}".format(
expected_row_start_offset, resp.results.startRowOffset
)
Expand Down
Loading