Redact the URL query parameters from the urllib3.connectionpool logs #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkazia-db
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
Signed-off-by: Mubashir Kazia <[email protected]>
mkazia-db
force-pushed
the
url-param-log-redaction
branch
from
09ceb9c to
f0aec2b
Compare
Signed-off-by: Mubashir Kazia <[email protected]>
jackyhu-db
reviewed
Feb 2, 2024
jackyhu-db
approved these changes
Feb 2, 2024
jackyhu-db
reviewed
Feb 2, 2024
Signed-off-by: Mubashir Kazia <[email protected]>
andrefurlan-db
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LogLevel is set to DEBUG, urllib3 is logging all the request URLs. These URLs include pre-signed URLs which are sensitive and should not be logged. This implements a redacting filter for logging that will replace param values in the URL with . The URLs will be logged with URL path and param names and without the original param values.