[PECO-1435] Restore tests.py to the test suite
#331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 25, 2024 16:25
Signed-off-by: Jesse Whitehouse <[email protected]>
FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_auth_args - ... FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_authtoken_passthrough FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_close_uses_the_correct_session_id FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_closing_connection_closes_commands FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_context_manager_closes_connection FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_cursor_keeps_connection_alive FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_disable_pandas_respected FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_execute_parameter_passthrough FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_executemany_parameter_passhthrough_and_uses_last_result_set FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_executing_multiple_commands_uses_the_most_recent_command FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_finalizer_closes_abandoned_connection FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_row_number_respected FAILED tests/unit/test_clientTestSuite.py::ClientTestSuite::test_staging_operation_response_is_handled Signed-off-by: Jesse Whitehouse <[email protected]>
This should have been incorporated into #170 Signed-off-by: Jesse Whitehouse <[email protected]>
Since this test was written we now set the user agent and auth provider on every ThriftBackend creation. The fix here is to unpack the remaining call_args into _ with the unpack operator `*` Signed-off-by: Jesse Whitehouse <[email protected]>
This test is superceded by test_access_token_provider Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
benc-db
reviewed
Jan 25, 2024
benc-db
approved these changes
Jan 25, 2024
…m rn Signed-off-by: Jesse Whitehouse <[email protected]>
benc-db
approved these changes
Jan 26, 2024
Signed-off-by: Jesse Whitehouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #317. Somewhere about 18 months ago we move to from using unittest to pytest as our test runner. These tests were contained in a file called
tests.pywhich would not be auto-discovered bypytestbecause it doesn't have the prefixtest_in its filename.13 of these tests failed at-first. Because we've done 18 months of development since then and changed some of the internal interfaces that these unit tests exercise. So I've gone through and updated as many of the tests as I could within a couple hours to get them to pass. Now only 2 of them fail.
I chose not to fix those remaining two because they deal with the internal interface for handling arrow batches which I'm about to rewrite anyway. I'll pick these up in that effort next week.