Skip to content

Add a marker to indicate Python 3.10 isn't supported #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add a marker to indicate Python 3.10 isn't supported #33

wants to merge 1 commit into from

Conversation

kaxil
Copy link

@kaxil kaxil commented Aug 17, 2022

Currently, Python 3.10 isn't supported (GitHub Issue: #26), but as this marker here says it works for all Python version, if a user tries to install it on Py 3.10 it fails with unhelpful messages.

More about environment markers: https://peps.python.org/pep-0508/#environment-markers

@susodapop
Copy link
Contributor

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@susodapop
Copy link
Contributor

Also, agreed this should have been included in #27. That said, Python 3.10 support will be incorporated in the next release to Pypi. So changing this here isn't exactly necessary.

Currently, Python 3.10 isn't supported (GitHub Issue: #26), but as this marker here says it works for all Python version, if a user tries to install it on Py 3.10 it fails with unhelpful messages.

Signed-off-by: Kaxil Naik <[email protected]>
@kaxil
Copy link
Author

kaxil commented Aug 17, 2022

Thanks @susodapop , updated with signed commit message, Airflow Commiter and PMC member here 👋 . We are using this as dep for the Airflow-Databricks provider

Also, agreed this should have been included in #27. That said, Python 3.10 support will be incorporated in the next release to Pypi. So changing this here isn't exactly necessary.

Ideally, we you can release v2.0.4 with this change, this should help the current user making this mistake and then you can remove it when you actually add support for 3.10 in the next release.

@susodapop
Copy link
Contributor

NTMU 👋

Sorry what I meant to say is that we're working on releasing Python 3.10 support in v2.0.4 within a number of hours. We're just running the e2e tests for the change now. Making a special release with your proposed one-line change wouldn't happen measurably sooner.

@kaxil
Copy link
Author

kaxil commented Aug 17, 2022

NTMU 👋

Sorry what I meant to say is that we're working on releasing Python 3.10 support in v2.0.4 within a number of hours. We're just running the e2e tests for the change now. Making a special release with your proposed one-line change wouldn't happen measurably sooner.

Oh, that's awesome ❤️ . I didn't know you were planning 2.0.4 in few hours. That's good to know, we will hold off our release for astronomer/astronomer-providers#588 too 🚀

I will close this PR, thanks for you work

@kaxil kaxil closed this Aug 17, 2022
@kaxil kaxil deleted the patch-1 branch August 17, 2022 18:54
@susodapop
Copy link
Contributor

v2.0.4 is now live on Pypi 🚀

@kaxil
Copy link
Author

kaxil commented Aug 17, 2022

v2.0.4 is now live on Pypi 🚀

I can confirm it works for us now, thanks for the quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants