[sqlalchemy] Add table and column comment support #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Signed-off-by: Christophe Bornet <[email protected]> Signed-off-by: Jesse Whitehouse <[email protected]> Co-authored-by: Jesse Whitehouse <[email protected]>
Fix: this allows component reflection test to pass Databricks returns an empty string in the REMARKS column rather than a `NoneType`. Signed-off-by: Jesse Whitehouse <[email protected]>
* Add support for table comments Signed-off-by: Christophe Bornet <[email protected]> * Use per-table DTE to get the table comments Signed-off-by: Christophe Bornet <[email protected]> * Revert pytest.ini change Signed-off-by: Jesse Whitehouse <[email protected]> * Fix typo in test name for columns. Move .engine and .compile into a base class. Scaffold in the Table Comment unit tests. Signed-off-by: Jesse Whitehouse <[email protected]> * Add unit tests for table comments Signed-off-by: Jesse Whitehouse <[email protected]> * Revert overrides since these aren't needed after #328 Signed-off-by: Jesse Whitehouse <[email protected]> * Stop skipping table comment portions of ComponentReflectionTest Signed-off-by: Jesse Whitehouse <[email protected]> * Move DTE parsing into _parse.py Signed-off-by: Jesse Whitehouse <[email protected]> * Add e2e test using inspector Signed-off-by: Jesse Whitehouse <[email protected]> * Add unit test for new method in _parse.py Signed-off-by: Jesse Whitehouse <[email protected]> * Fix assertion in column comment test This was missed in #328 Signed-off-by: Jesse Whitehouse <[email protected]> --------- Signed-off-by: Christophe Bornet <[email protected]> Signed-off-by: Jesse Whitehouse <[email protected]> Co-authored-by: Jesse Whitehouse <[email protected]>
susodapop
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
Signed-off-by: Jesse Whitehouse <[email protected]>
cbornet
reviewed
Jan 24, 2024
|
|
||
| comment = inspector.get_table_comment(tbl_name) | ||
|
|
||
| assert comment == {"text": "table comment"} |
There was a problem hiding this comment.
Could also check column comments with inspector.get_columns ?
There was a problem hiding this comment.
Yes, you already did this with the test_column_comments, no? I can rewrite it to use the same fixtures and be more efficient.
There was a problem hiding this comment.
woof, haven't had my coffee yet. i understand your comment now. I've added an extra method to this test class that simply checks for reflection of the column comment. thank you!
Signed-off-by: Jesse Whitehouse <[email protected]>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
rcypher-databricks
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates the changes from #306 and #308 after review + tests + refactor which I placed into a staging branch to coordinate reviews and testing.