-
Notifications
You must be signed in to change notification settings - Fork 106
[PECO-1286] Complex types tests #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
|
||
import pytest | ||
from numpy import ndarray | ||
|
||
from tests.e2e.test_driver import PySQLPytestTestCase | ||
|
||
|
||
class TestComplexTypes(PySQLPytestTestCase): | ||
@pytest.fixture(scope="class") | ||
def table_fixture(self): | ||
"""A pytest fixture that creates a table with a complex type, inserts a record, yields, and then drops the table""" | ||
|
||
with self.cursor() as cursor: | ||
# Create the table | ||
cursor.execute( | ||
""" | ||
CREATE TABLE IF NOT EXISTS pysql_test_complex_types_table ( | ||
array_col ARRAY<STRING>, | ||
map_col MAP<STRING, INTEGER>, | ||
struct_col STRUCT<field1: STRING, field2: INTEGER> | ||
) | ||
""" | ||
) | ||
# Insert a record | ||
cursor.execute( | ||
""" | ||
INSERT INTO pysql_test_complex_types_table | ||
VALUES ( | ||
ARRAY('a', 'b', 'c'), | ||
MAP('a', 1, 'b', 2, 'c', 3), | ||
NAMED_STRUCT('field1', 'a', 'field2', 1) | ||
) | ||
""" | ||
) | ||
yield | ||
# Clean up the table after the test | ||
cursor.execute("DROP TABLE IF EXISTS pysql_test_complex_types_table") | ||
|
||
@pytest.mark.parametrize( | ||
"field,expected_type", | ||
[("array_col", ndarray), ("map_col", list), ("struct_col", dict)], | ||
) | ||
def test_read_complex_types_as_arrow(self, field, expected_type, table_fixture): | ||
"""Confirms the return types of a complex type field when reading as arrow""" | ||
|
||
with self.cursor() as cursor: | ||
result = cursor.execute( | ||
"SELECT * FROM pysql_test_complex_types_table LIMIT 1" | ||
).fetchone() | ||
|
||
assert isinstance(result[field], expected_type) | ||
|
||
@pytest.mark.parametrize("field", [("array_col"), ("map_col"), ("struct_col")]) | ||
def test_read_complex_types_as_string(self, field, table_fixture): | ||
"""Confirms the return type of a complex type that is returned as a string""" | ||
with self.cursor( | ||
extra_params={"_use_arrow_native_complex_types": False} | ||
) as cursor: | ||
result = cursor.execute( | ||
"SELECT * FROM pysql_test_complex_types_table LIMIT 1" | ||
).fetchone() | ||
|
||
assert isinstance(result[field], str) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is MAP not returned as a Dict[str, any]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought but this seems to be controlled by
pyarrow
. Updating to use adict()
is a potential improvement we could implement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear if it would be an improvement. If this is the native type, let's leave it be.