[Cleanup] Move connector files to root #2
Conversation
susodapop
requested review from
arikfr,
a team and
dragqueen95
and removed request for
a team
susodapop
force-pushed
the
idiomatic-layout
branch
from
6cd6d19 to
688248a
Compare
There was a problem hiding this comment.
As we are re-structuring the files, and there is no CI running on the PR at the moment, we potentially may break something.
I wonder when you are planning to enable a CI on the repo? Is it possible to enable any sort of basic CI before doing any more structural changes? (maybe for start just a CI to run the basic unit test but not the end to end test)? (this doesn't need to be in this PR) what do you think @susodapop?
| cryptography==35.0.0 | ||
| thrift==0.13.0 | ||
| pandas==1.3.4 | ||
| future==0.18.2 |
There was a problem hiding this comment.
I see this file is not moved, but removed. isn't the list of dependencies, dev_requirements.txt required anymore?
There was a problem hiding this comment.
After we merged #1, the dev environment specification is contained in pyproject.toml so there's no need for a separate dev_requirements.txt file. If we need to add more development dependencies in the future we can do that from the command line with poetry add <package name> --dev.
| @@ -1,31 +0,0 @@ | |||
| [metadata] | |||
| name = databricks-sql-connector | |||
There was a problem hiding this comment.
did another file replace this file now?
There was a problem hiding this comment.
Yep, as part of #1 we replaced setup.cfg with pyproject.toml since we're using poetry instead of distutils for build / publish now.
|
Good points about unit testing. We can't add automated CI tests without additional commits. But I can run these tests manually. I'm working on that now. |
unit tests to fail.
Base.py alembic debugging line removed
Description
This PR moves all the source code into the root of the repository. The previous nesting was the result of retaining the commit history when this connector was part of another Databricks repository.
HISTORY->CHANGELOG.mdpyproject.tomlso that the CHANGELOG will be copied into the distribution packageLICENSEfile with the Apache 2.0 license text.