Relax pandas dependency constraint to allow ^2.0.0 (#102) #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps all previous versions supported, while allowing the use of pandas `^2.0.0`. The `<1.4.0` constraint for python 3.7 makes package resolution much faster since `>=1.4.0` doesn't support python 3.7 anyways. Signed-off-by: Daniel Segesdi <[email protected]>
itsdani
requested review from
susodapop,
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
|
Review coming soon 👀 |
added 3 commits
July 12, 2023 14:53
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
…e changes Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
approved these changes
Jul 12, 2023
susodapop
pushed a commit
to unj1m/databricks-sql-python
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Daniel Segesdi <[email protected]> Signed-off-by: Jesse Whitehouse <[email protected]> Co-authored-by: Jesse Whitehouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This keeps all previous versions supported, while allowing the use of
pandas >=2.0.0.The
<1.4.0constraint forpython 3.7makes package resolution much faster sincepandas >=1.4.0doesn't support python 3.7 anyways.How is this tested?
3.7.17,3.10.7and3.11.1)Related Tickets & Documents
#102