Fix proxy connection pool creation #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebbegg
requested review from
susodapop,
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
Signed-off-by: Sebastian Eckweiler <[email protected]>
Signed-off-by: Sebastian Eckweiler <[email protected]>
|
@susodapop please give the proper love to this PR. Thanks @sebbegg for coming up with this |
|
Thanks for the feedback. Fear not, this hasn’t escaped our notice. It
should merge and be released in the next week or so.
…On Tue, Jun 27, 2023 at 12:23 PM Daniele Antonio Maggio < ***@***.***> wrote:
@susodapop <https://github.com/susodapop> please give the proper love to
this PR.
We were having issues with latest 2.7.0 and I can confirm that when using
a proxy, the library requires the changes in this PR 👍
Thanks @sebbegg <https://github.com/sebbegg> for coming up with this
—
Reply to this email directly, view it on GitHub
<#158 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECG7B33FFSCYHRBO5J5GK3XNMJI3ANCNFSM6AAAAAAZRPJAAI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Any update when this fix will be released @susodapop ? We are facing the same issue and are working with a patched version with @sebbegg 's fix ATM. |
|
It will be part of the next release this week.
…On Mon, Jul 10, 2023 at 2:01 AM Marc Gomez ***@***.***> wrote:
Any update when this fix will be released @susodapop
<https://github.com/susodapop> ? We are facing the same issue and are
working with a patched version with @sebbegg <https://github.com/sebbegg>
's fix ATM.
—
Reply to this email directly, view it on GitHub
<#158 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECG7B4ANGHHCU5YK5GEDU3XPOSDRANCNFSM6AAAAAAZRPJAAI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
added 2 commits
July 11, 2023 19:32
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
pushed a commit
to unj1m/databricks-sql-python
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Sebastian Eckweiler <[email protected]> Signed-off-by: Jesse Whitehouse <[email protected]> Co-authored-by: Sebastian Eckweiler <[email protected]> Co-authored-by: Jesse Whitehouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled across this while trying to use the connection from within a proxy environment.
As far as I can tell the proxy cool creation is passed the wrong host/port and was missing the
httpsscheme.Without the proper schema urllib won't do a proper
CONNECTcall and the requests later on will fail.It appears
realhostandrealportin theTHttpClientwere not used anywhere, but were probably intended for the proxy use-case?Tested this locally against our databricks subscription.
Sebastian Eckweiler ([email protected]), Mercedes-Benz AG on behalf of MBition GmbH (Imprint)