Skip to content

[PECO-832] Make e2e tests automatically discoverable to VSCode #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 23, 2023

Conversation

susodapop
Copy link
Contributor

This pull request makes life easier developing this repository in VSCode or any visual debugger:

  1. Moves the staging ingestion tests into a separate file so they don't try to run automatically whenever you run PySQLCoreTestSuite
  2. Renames driver_tests.py -> test_driver.py to match Python / unittest / pytest convention
  3. Adds pytest-dotenv dependency so we can read auth credentials from test.env

Before this change it wasn't possible to run the e2e tests or debug them using VSCode.

Jesse Whitehouse added 8 commits June 23, 2023 17:52
Signed-off-by: Jesse Whitehouse <[email protected]>
intentionally skipped.

Prior to this change, the whole test suite was failing even when we
marked the staging ingestion tests to be skipped.

Signed-off-by: Jesse Whitehouse <[email protected]>
This follows the pattern of dbt-databricks

Signed-off-by: Jesse Whitehouse <[email protected]>
This was only when we needed DECO infrastructure. Not applicable for
local development

Signed-off-by: Jesse Whitehouse <[email protected]>
@susodapop
Copy link
Contributor Author

I rebased onto main to incorporate the redacted logging fix in #153.

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Jesse Whitehouse <[email protected]>
@susodapop susodapop merged commit fecfa88 into main Jun 23, 2023
@susodapop susodapop deleted the PECO-832 branch June 23, 2023 23:00
susodapop pushed a commit to unj1m/databricks-sql-python that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants