Skip to content

Cloud Fetch e2e tests #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Conversation

mattdeekay
Copy link
Contributor

E2e tests comparing cloud fetch and non-cloud fetch outputs for the same query with an assortment of query row limits, number of cloud fetch downloader threads, and lz4 compression.

@mattdeekay mattdeekay requested a review from susodapop as a code owner June 21, 2023 22:42
@mattdeekay mattdeekay self-assigned this Jun 21, 2023
@mattdeekay mattdeekay force-pushed the cloudfetch-e2e-tests branch 2 times, most recently from 2f20c3b to a1677e2 Compare June 27, 2023 03:45
@mattdeekay mattdeekay force-pushed the cloudfetch-e2e-tests branch from a1677e2 to f6ce9a2 Compare June 27, 2023 22:29
Signed-off-by: Matthew Kim <[email protected]>
@mattdeekay mattdeekay force-pushed the cloudfetch-e2e-tests branch from f6ce9a2 to fa6855b Compare June 27, 2023 22:32
Copy link
Contributor

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good. Just a few questions about specifics.

Copy link
Contributor

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about what's needed for the the e2e test to run successfully. That will be important in the coming weeks when we enable automatic e2e tests with github actions.

@mattdeekay mattdeekay merged commit 759401c into databricks:main Jul 7, 2023
susodapop pushed a commit to unj1m/databricks-sql-python that referenced this pull request Sep 19, 2023
* Cloud Fetch e2e tests

Signed-off-by: Matthew Kim <[email protected]>

* Test case works for e2-dogfood shared unity catalog

Signed-off-by: Matthew Kim <[email protected]>

* Moving test to LargeQueriesSuite and setting catalog to hive_metastore

Signed-off-by: Matthew Kim <[email protected]>

* Align default value of buffer_size_bytes in driver tests

Signed-off-by: Matthew Kim <[email protected]>

* Adding comment to specify what's needed to run successfully

Signed-off-by: Matthew Kim <[email protected]>

---------

Signed-off-by: Matthew Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants