-
Notifications
You must be signed in to change notification settings - Fork 106
Cloud Fetch e2e tests #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2f20c3b
to
a1677e2
Compare
a1677e2
to
f6ce9a2
Compare
Signed-off-by: Matthew Kim <[email protected]>
f6ce9a2
to
fa6855b
Compare
Signed-off-by: Matthew Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks good. Just a few questions about specifics.
Signed-off-by: Matthew Kim <[email protected]>
Signed-off-by: Matthew Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment about what's needed for the the e2e test to run successfully. That will be important in the coming weeks when we enable automatic e2e tests with github actions.
Signed-off-by: Matthew Kim <[email protected]>
* Cloud Fetch e2e tests Signed-off-by: Matthew Kim <[email protected]> * Test case works for e2-dogfood shared unity catalog Signed-off-by: Matthew Kim <[email protected]> * Moving test to LargeQueriesSuite and setting catalog to hive_metastore Signed-off-by: Matthew Kim <[email protected]> * Align default value of buffer_size_bytes in driver tests Signed-off-by: Matthew Kim <[email protected]> * Adding comment to specify what's needed to run successfully Signed-off-by: Matthew Kim <[email protected]> --------- Signed-off-by: Matthew Kim <[email protected]>
E2e tests comparing cloud fetch and non-cloud fetch outputs for the same query with an assortment of query row limits, number of cloud fetch downloader threads, and lz4 compression.