Default socket timeout to 15 min #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Kim <[email protected]>
mattdeekay
force-pushed
the
default-socket-timeout
branch
from
54b697f to
878d1f2
Compare
mattdeekay
requested review from
susodapop,
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
Signed-off-by: Matthew Kim <[email protected]>
mattdeekay
force-pushed
the
default-socket-timeout
branch
from
7090d0d to
c6af108
Compare
Signed-off-by: Matthew Kim <[email protected]>
susodapop
reviewed
Jun 6, 2023
Signed-off-by: Matthew Kim <[email protected]>
Signed-off-by: Matthew Kim <[email protected]>
Signed-off-by: Matthew Kim <[email protected]>
mattdeekay
changed the title
Signed-off-by: Matthew Kim <[email protected]>
susodapop
approved these changes
Jun 7, 2023
susodapop
pushed a commit
to unj1m/databricks-sql-python
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Matthew Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if socket timeout is not specified in the kwargs, there will be no socket timeout. As per PECO-742, a single request should not block indefinitely. If the server side does not respond within one minute, we should timeout. We'll set the timeout conservatively to 15 min