Add DCO to CONTRIBUTING.md #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moderakh
approved these changes
Jul 13, 2022
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
The check itself comes from the DCO Check GitHub app. These apps are tied directly to GitHub which is why the `app_id` is a known constant. It's the same id regardless of the repository it monitors. These were forked from MLFlow's public repository: https: //github.com/mlflow/mlflow/blob/master/.github/workflows/notify-dco-failure.js Signed-off-by: Jesse Whitehouse <[email protected]>
This reverts commit 16b438c. We're going to use a GitHub Action for DCO checks instead of a GH App Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
|
Array |
Intentionally not signing this commit to make sure the automated DCO check behaves as expected. Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
This reverts commit 0a00449. Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off. One or more of your commits is missing this sign-off message. You can retroactively apply this sign-off with an interactive rebase. |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
yunbodeng-db
approved these changes
Jul 29, 2022
|
We need to do this to all other connectors as well? |
|
Yes I've created tracking tickets internally to implement this for NodeJS and Go. |
This was referenced Aug 16, 2022
moderakh
pushed a commit
to moderakh/databricks-sql-python
that referenced
this pull request
Aug 24, 2022
Includes a GitHub Action which checks for a valid sign-off on every proposed commit Signed-off-by: Moe Derakhshani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Databricks standard DCO to the CONTRIBUTING guide.
Also adds a GitHub Action step which checks each commit in the pull request for a DCO sign-off and leaves a comment if this check fails.
One challenging aspect of this approach is that our current DCO check step doesn't have any
outputshooks that let us access its list of which commits failed the DCO check. I can write a custom action step that forks the existing behaviour and sets those outputs as a follow-up if it becomes necessary.For now, any member of this org can see exactly which commits failed the DCO check by examining the PR Check results. These aren't visible to outside contributors, though, which is not as convenient.
Example comment: