-
Notifications
You must be signed in to change notification settings - Fork 106
Disable non_native_boolean_check_constraint #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable non_native_boolean_check_constraint #120
Conversation
The change LGTM. Please sign-off the commit as described in CONTRIBUTING.md
|
4cef2c4
to
3fac5ef
Compare
signed-off-by: Bogdan Kyryliuk <[email protected]>
3fac5ef
to
0672be3
Compare
had a typo in the signature :) fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests work for me. I need to push some changes to sync this back with main
but it will merge today.
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Oh this is actually cool. I had to program something similar into our e2e tests when back-porting support for sqlalchemy==1.3.x. I wonder if I can remove those constraints now. I'm going to check that before I merge. |
Signed-off-by: Jesse Whitehouse <[email protected]>
Yessssss that worked. |
--------- Signed-off-by: Bogdan Kyryliuk <[email protected]> Signed-off-by: Jesse Whitehouse <[email protected]> Co-authored-by: Jesse Whitehouse <[email protected]>
Disable non_native_boolean_check_constraint as it is not supported by databricks.
It is true by default: https://github.com/zzzeek/sqlalchemy/blob/main/lib/sqlalchemy/engine/default.py#L162
Tested via monkeypatching out code
error msg: