remove names from dataframe_from_2d_array
#302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
reviewed
Oct 27, 2023
| @@ -135,7 +135,7 @@ def column_from_1d_array(array: Any, *, dtype: DType, name: str = '') -> Column: | |||
| """ | |||
| ... | |||
|
|
|||
| def dataframe_from_2d_array(array: Any, *, names: Sequence[str], dtypes: Mapping[str, Any]) -> DataFrame: | |||
| def dataframe_from_2d_array(array: Any, *, dtypes: Mapping[str, Any]) -> DataFrame: | |||
There was a problem hiding this comment.
Does Mapping guarantee ordering? As far as I can tell it only guarantees that __getitem__, __len__, and __iter__ are supported, but doesn't guarantee any specific order for __iter__?
Not sure if this is actually an issue in practice though. Worst case we could dictate Dict instead of Mapping here?
kkraus14
approved these changes
Oct 27, 2023
| @@ -137,7 +137,7 @@ def column_from_1d_array(array: Any, *, dtype: DType, name: str = '') -> Column: | |||
| """ | |||
| ... | |||
|
|
|||
| def dataframe_from_2d_array(array: Any, *, names: Sequence[str], dtypes: Mapping[str, Any]) -> DataFrame: | |||
| def dataframe_from_2d_array(array: Any, *, dtypes: Dict[str, Any]) -> DataFrame: | |||
There was a problem hiding this comment.
Nitpick: but we have a schema function that is logically equivalent to what we expect here. Maybe rename this parameter to schema to be consistent?
Seeing dtypes makes me think I can pass a sequence.
There was a problem hiding this comment.
you're right thanks for spotting this
MarcoGorelli
added a commit
to MarcoGorelli/dataframe-api
that referenced
this pull request
Oct 31, 2023
* remove `names` from dataframe_from_2d_array * Mapping -> Dict * rename to schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys of
dtypesalready give the column names, and Python dicts are orderedIf anyone needs to reorder the names after construction, they can put
.selectafter this method anywayBut having to always provide both
dtypesandnamesis quite annoying from a user perspective