Skip to content

Fixup typing of Namespace #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fixup typing of Namespace #301

merged 1 commit into from
Oct 26, 2023

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Oct 26, 2023 •
edited
Loading

I'd missed a couple of details in my implementation, the more accurate and usable the typing is the more that can be avoided

@MarcoGorelli MarcoGorelli added the static typing type annotations, use of type checkers directly from the spec label Oct 26, 2023
@MarcoGorelli MarcoGorelli marked this pull request as draft October 26, 2023 08:51
@MarcoGorelli MarcoGorelli marked this pull request as ready for review October 26, 2023 10:04
@MarcoGorelli MarcoGorelli merged commit fcfb54f into data-apis:main Oct 26, 2023
@MarcoGorelli
Copy link
Contributor Author

merging as this only affects typing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
static typing type annotations, use of type checkers directly from the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarcoGorelli