Skip to content

Add basic datetime functionality #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 26, 2023
Merged

Add basic datetime functionality #275

merged 8 commits into from
Oct 26, 2023

Conversation

MarcoGorelli
Copy link
Contributor

closes #260

kkraus14
kkraus14 reviewed Oct 5, 2023
View reviewed changes
@MarcoGorelli
Copy link
Contributor Author

I've removed floor, we can discuss that one later, let's start with the simple ones

@MarcoGorelli MarcoGorelli mentioned this pull request Oct 8, 2023
Closed
rgommers
rgommers reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marco. This all looks pretty logical. It'd be useful to add to the spec explicitly that the returned columns here all have int64 (I think?) dtype.

@MarcoGorelli
Copy link
Contributor Author

Thanks

Not necessarily, some of these could be unsigned

@MarcoGorelli
Copy link
Contributor Author

approved in today's call

@MarcoGorelli MarcoGorelli merged commit 242103e into data-apis:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

@kkraus14 kkraus14 kkraus14 left review comments

Assignees
No one assigned
Labels
API design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datetime functionality
3 participants
@MarcoGorelli @rgommers @kkraus14