Prefer str | list[str] over Sequence[str]
#240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
Aug 27, 2023
|
Are there any concerns about people wanting to be able to pass iterables other than list types? I.E. tuples or anything else? |
|
thanks for your reviews not sure it's worth worrying about tuples tbh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #212
This would make it clearer that you can either pass a single column name, or a list of column names.
Sequence[str]would accept'abcd'but it's ambiguous whether that means "column 'abcd'" or "columns 'a', 'b', 'c', 'd'", given thatstris itself aSequence[str]