Add dataframe.join #238
Merged
Add dataframe.join #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
join
branch
2 times, most recently
from
954322e to
a5f5954
Compare
kkraus14
reviewed
Aug 28, 2023
Comment on lines
+917
to
+919
| how : str | ||
| Kind of join to perform. | ||
| Must be one of {'left', 'inner', 'outer'}. |
There was a problem hiding this comment.
I know right joins can be modeled as left joins with the inputs swapped, but any reason not to support right as a join type here?
There was a problem hiding this comment.
I know right joins can be modeled as left joins with the inputs swapped
exactly, so if the idea is to make a minimal API, right joins probably aren't needed. have never seem them in practice anyway
There was a problem hiding this comment.
We can always add them later without it being a breaking change, so I'm good with not including them until there's clear feedback that they're needed / wanted.
kkraus14
approved these changes
Aug 28, 2023
|
cool, thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #237