Skip to content

Note __pow__ return type #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 29, 2023
Merged

Note __pow__ return type #182

merged 5 commits into from
Jun 29, 2023

Conversation

MarcoGorelli
Copy link
Contributor

closes #174

rgommers
rgommers reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"integer" and "float" are perhaps not precise enough (those are Python scalar types, not dataframe dtypes). How about saying something about the input dtype being preserved in all cases if the right-hand operand is integer?

@MarcoGorelli
Copy link
Contributor Author

is it always preserved though? upcasting could happen, such as int8 -> int16. maybe that doesn't need standardising on, but noting that integer dtype stays integer dtype does

kkraus14
kkraus14 reviewed Jun 21, 2023
View reviewed changes
kkraus14
kkraus14 reviewed Jun 29, 2023
View reviewed changes
kkraus14
kkraus14 reviewed Jun 29, 2023
View reviewed changes
@MarcoGorelli
Copy link
Contributor Author

merging, thanks all

@MarcoGorelli MarcoGorelli merged commit 2c94312 into data-apis:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type of pow
3 participants
@MarcoGorelli @rgommers @kkraus14