add Column.__dataframe_namespace__
#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
requested changes
May 31, 2023
There was a problem hiding this comment.
I understand the use case, but https://data-apis.org/dataframe-api/draft/purpose_and_scope.html#checking-a-dataframe-object-for-compliance strongly implies that this method should only be implemented by standard-compliant dataframe objects, and that it's the way to check whether an object is such a dataframe.
I think it should probably be __column_namespace__ instead, as the one way to check if this is a standard-compliant Column object. And it additionally can guarantee that it will return the same namespace as for DataFrame.__dataframe_namespace__.
rgommers
approved these changes
Jun 20, 2023
rgommers
changed the title
Column.__dataframe_namespace__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty minor, hope this is uncontroversial
use-case: you have a function which accepts a Column as input, and you need to access some method from the top-level namespace