Skip to content

move from_sequence to namespace #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 11, 2023
Merged

move from_sequence to namespace #164

merged 4 commits into from
May 11, 2023

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented May 4, 2023 •
edited
Loading

closes #162

jorisvandenbossche
jorisvandenbossche reviewed May 5, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same for DataFrame.from_dict?

@MarcoGorelli
Copy link
Contributor Author

good one, thanks for your review - have updated

@MarcoGorelli
Copy link
Contributor Author

anything missing, or OK to merge?

rgommers
rgommers approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks about ready to me. The dtype: str keyword may still change based on gh-155, but that can be done afterwards to not block this PR or other ones - that needs its own PR to deal with dtype's consistently all in one go.

spec/API_specification/dataframe_api/__init__.py Outdated

__dataframe_api_version__: str = "YYYY.MM"
"""
String representing the version of the DataFrame API specification to which the
conforming implementation adheres.
"""

def column_from_sequence(sequence: Sequence[object], dtype: dtype) -> Column:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider making dtype keyword-only?

MarcoGorelli
MarcoGorelli commented May 11, 2023
View reviewed changes
@MarcoGorelli
Copy link
Contributor Author

merging then, thanks for reviewing!

@MarcoGorelli MarcoGorelli merged commit 27501f8 into data-apis:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
API design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inserting a column of nans / namespace.column_class
3 participants
@MarcoGorelli @rgommers @jorisvandenbossche