-
Notifications
You must be signed in to change notification settings - Fork 21
add Column.from_sequence #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marco, this looks good. The one important thing that I think is missing is this (from gh-121): "Each element of input sequences must be of that dtype."
I believe the idea was that it should be the relevant Python scalar type, or something that duck types that. So for any integer type, it's int
(or an object that has __int__
), for datetimes, datetime.datetime
instances, etc. EDIT: for categoricals, the underlying dict
type
and no need to describe that, I'm doing that in a separate page, so it can be linked to. EDIT: that's gh-153 |
I guess if |
69a0105
to
1b1b9ef
Compare
``dtype``, the corresponding Python builtin scalar type, or | ||
coercible to that Python scalar type. | ||
dtype : str | ||
Dtype of result. Must be specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start listing the possible values for the strings to specify dtypes? (for example, we don't necessarily want to support all variations of the same dtype that numpy supports?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh that is a good catch - this is the very first dtype
keyword. There's multiple ways we could go there, this is important enough to open a separate issue about. Let me do so now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in gh-155
closes #121