Skip to content

Search function broken - asking to activate Javascript? #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomNicholas opened this issue Feb 9, 2024 · 4 comments
Closed

Search function broken - asking to activate Javascript? #24

TomNicholas opened this issue Feb 9, 2024 · 4 comments

Comments

@TomNicholas
Copy link

TomNicholas commented Feb 9, 2024

Hi,

This is happening when I try to search on the website (e.g. https://data-apis.org/array-api/2022.12/search.html?q=broadcast_like#)

Screenshot 2024-02-09 at 1 21 41 PM

I don't think this is my fault - I've definitely got javascript enabled, and besides I also tried this on mobile and saw the same error.

@kgryte
Copy link
Contributor

kgryte commented Feb 10, 2024

Hmm...odd. Search is working. For example, if you search sine (https://data-apis.org/array-api/2022.12/search.html?q=sine), you get search results.

Not sure why the banner is appearing. We recently updated Sphinx, so this may have something to do with it.

@rgommers
Copy link
Member

Thanks for reporting this @TomNicholas. This is bashtage/sphinx-material#132. Looks like Sphinx 5.x is unaffected, while with 6.x this is visible in the search pages of the non-default versions of the docs.

Search indeed still works, so it's simply a spurious warning.

We had to upgrade Sphinx in data-apis/array-api#735. I'll see if there's an in-between version that we can use for now. Hopefully the theme bug gets fixed in the near future.

@rgommers
Copy link
Member

Hmm, going back to Sphinx 5.3.0 makes other build warnings re-appear, I think there's no good workaround here other than get the sphinx-material theme fixed.

@rgommers
Copy link
Member

rgommers commented Mar 5, 2024

This has been fixed by data-apis/array-api#758. The root cause was that Sphinx 5 stopped shipping jQuery. Installing it with sphinxcontrib-jquery restored the old behavior.

Thanks @TomNicholas and @kgryte

@rgommers rgommers closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants