Skip to content

version switcher on deployed website disappeared #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rgommers opened this issue Feb 22, 2024 · 3 comments · Fixed by #758
Closed

version switcher on deployed website disappeared #753

rgommers opened this issue Feb 22, 2024 · 3 comments · Fixed by #758
Labels
Deployment Specification deployment (e.g., to a website).

Comments

@rgommers
Copy link
Member

Almost certainly caused by gh-735.

Also xref a related issue with a JS warning about the search results, which was also due to a Sphinx version upgrade: data-apis/data-apis.github.io#24.

@rgommers rgommers added the Deployment Specification deployment (e.g., to a website). label Feb 22, 2024
@rgommers
Copy link
Member Author

This works in the demo site of the theme (see [here](https://bashtage.github.io/sphinx-material/customization.html, also for docs on version dropdown usage).

We have a slightly unusual setup here, but it's not clear what changed beyond an upgrade of Sphinx. Things do seem to land in the right places in the gh-pages branch.

A bit of info:

  <script src="_static/javascripts/version_dropdown.js"></script>
  <script>
    var json_loc = "../versions.json",
        target_loc = "../",
        text = "Versions";
    $( document ).ready( add_version_dropdown(json_loc, target_loc, text));
  </script>

Someone with more JavaScript skills can take it from here I hope:)

@asmeurer
Copy link
Member

I think it has to do with jquery. There was some change in sphinx at some point where they stopped shipping it or something like that.

@asmeurer
Copy link
Member

See sympy/sympy#24989. The fix here is probably the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Specification deployment (e.g., to a website).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants