Skip to content

Fix doc-requirements.txt to work with conda #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

asmeurer
Copy link
Member

pip treats dashes and underscores the same but conda does not. The package names here are actually dashes (pip just replaces an underscore with a dash) so this is more correct anyways.

pip treats dashes and underscores the same but conda does not. The package
names here are actually dashes (pip just replaces an underscore with a dash)
so this is more correct anyways.
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @asmeurer.

@kgryte kgryte added the Maintenance Bug fix, typo fix, or general maintenance. label Apr 30, 2024
@kgryte kgryte merged commit 69e2733 into data-apis:main Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants