-
Notifications
You must be signed in to change notification settings - Fork 53
Move special cases to notes sections #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kgryte. I went through the rendered version of everything (I think), and found two issues. There's more to do on this topic, but let's leave that until a later time (after tagging v2022.12
).
@rgommers Thanks for reviewing and catching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, in it goes.
This PR
array_object
which is documented in existing function API documentation. This addresses duplication and maintainability concerns..git-blame-ignore-revs
file in order to retain Git blame for documented special cases.Notes
.git-blame-ignore-revs
file. The omitted commit should not be included in the list of ignored commits as the changes are not simply reorganization and should be tracked via Git blame..git-blame-ignore-revs
file to be correct.