Skip to content

Add any/all specifications #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2020
Merged

Add any/all specifications #48

merged 3 commits into from
Oct 8, 2020

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Sep 24, 2020

This PR

  • adds a specification for all (logical AND)
  • adds a specification for any (logical OR)
  • is derived from comparing API signatures across array libraries.

Notes

  • The specified functions follow the same form as statistical functions in terms of keyword arguments.

  • Torch any and all are not currently publicly documented and do not support all dtypes; however, this is slated to change.

@kgryte kgryte mentioned this pull request Sep 24, 2020
Closed
rgommers
rgommers approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte. Seems straightforward, I'll merge this in a day or two unless there are more comments.

@kgryte
Copy link
Contributor Author

kgryte commented Sep 29, 2020

Great! Thanks for reviewing!

@kgryte
Copy link
Contributor Author

kgryte commented Oct 8, 2020

@rgommers I believe this is ready to be merged. :)

@rgommers rgommers merged commit 17945d7 into master Oct 8, 2020
@rgommers rgommers deleted the utils branch October 8, 2020 09:15
@rgommers
Copy link
Member

rgommers commented Oct 8, 2020

Thanks for the ping, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @rgommers