Skip to content

Disallow providing a stack of vectors to linalg.solve #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2021
Merged

Disallow providing a stack of vectors to linalg.solve #305

merged 2 commits into from
Nov 9, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 4, 2021

This PR

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Linear Algebra Linear algebra. labels Nov 4, 2021
@kgryte kgryte added this to the v2021 milestone Nov 4, 2021
@kgryte kgryte requested a review from asmeurer November 4, 2021 04:22
@leofang leofang self-requested a review November 4, 2021 17:59
@kgryte kgryte mentioned this pull request Nov 4, 2021
Closed
@kgryte @leofang
Update copy
8c8f0d6 
Co-authored-by: Leo Fang <[email protected]>
@kgryte kgryte removed the request for review from asmeurer November 9, 2021 21:01
@kgryte
Copy link
Contributor Author

kgryte commented Nov 9, 2021

Thanks, @leofang!

@kgryte kgryte merged commit f8bbcd4 into main Nov 9, 2021
@kgryte kgryte deleted the linalg-solve-broadcasting branch November 9, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang left review comments

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.

linalg.solve broadcasting behavior is ambiguous
2 participants
@kgryte @leofang