Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
linalg.lstsq
and replacing withlinalg.lstsq_solve
.linalg.lstsq
,linalg.lstsq_solve
only returns the least-squares solution. For singular values, rank, and residuals, users would be required to use other APIs already present in the specification (e.g.,linalg.svdvals
,linalg.matrix_rank
, etc). This is consistent with linear algebra design principles in which functionality should be orthogonal and not duplicated across APIs.Notes
lstsq_solve
was suggested by @lezcano as an alternative name forlstsq
only returning the solutions which does not conflict with existing API names in NumPy and SciPy (e.g.,least_squares
,lsqr
, etc).