Skip to content

Add a missing requirement for the producer of DLPack capsules #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

Add a missing requirement for the producer of DLPack capsules #186

merged 1 commit into from
May 25, 2021

Conversation

leofang
Copy link
Contributor

@leofang leofang commented May 25, 2021

See dmlc/dlpack#34 (comment). Manipulations of a PyCapsule rely on the precise knowledge of the capsule name (PyCapsule_GetPointer, PyCapsule_GetName, PyCapsule_IsValid, etc), so we cannot allow any ambiguity.

@hameerabbasi hameerabbasi mentioned this pull request May 25, 2021
Merged
8 tasks
@rgommers rgommers added the Narrative Content Narrative documentation content. label May 25, 2021
rgommers
rgommers approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Leo!

@rgommers rgommers merged commit 2472846 into data-apis:main May 25, 2021
@leofang leofang deleted the dltensor branch May 25, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leofang @rgommers