Skip to content

Note that in-place operators should not change the dtype of the array #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

asmeurer
Copy link
Member

Also note that the Python scalar rules do apply to in-place operators in
addition to normal operators.

The broadcasting rule here is duplicated in the broadcasting section. I'm
unsure if we should leave it duplicated or remove it so it is only mentioned
once.

Also note that the Python scalar rules do apply to in-place operators in
addition to normal operators.

The broadcasting rule here is duplicated in the broadcasting section. I'm
unsure if we should leave it duplicated or remove it so it is only mentioned
once.
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgommers rgommers force-pushed the main branch 3 times, most recently from 0607525 to 138e963 Compare April 19, 2021 20:25
@rgommers rgommers added Narrative Content Narrative documentation content. Maintenance Bug fix, typo fix, or general maintenance. labels Apr 20, 2021
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @asmeurer

@rgommers rgommers merged commit 3eded25 into data-apis:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants