Skip to content

Add slogdet specification #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 12, 2021
Merged

Add slogdet specification #111

merged 14 commits into from
May 12, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jan 14, 2021 •
edited
Loading

This PR

  • specifies an interface for computing the sign and natural logarithm of the absolute value of the determinant.
  • is derived from comparing signatures across array libraries.

Notes

  • The slogdet interface is spec'd to return a namedtuple as more than one output array is returned.

  • Following Torch, MXNet, TF, NumPy, CuPy, and JAX and maintaining consistency with det, this proposal allows for providing a stack of square matrices.

@rgommers rgommers added the API extension Adds new functions or objects to the API. label Mar 20, 2021
@rgommers rgommers force-pushed the main branch 3 times, most recently from 0607525 to 138e963 Compare April 19, 2021 20:25
@kgryte
Copy link
Contributor Author

kgryte commented May 12, 2021

Thanks, @leofang, for the review. This is ready for merge...

@kgryte kgryte merged commit 059e4fe into main May 12, 2021
@kgryte kgryte deleted the slogdet branch May 12, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

@leofang leofang leofang approved these changes

Assignees
No one assigned
Labels
API extension Adds new functions or objects to the API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgryte @rgommers @leofang