Filter undefined dtypes in hh.mutually_promotable_dtypes()
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmeurer
reviewed
Oct 28, 2021
array_api_tests/__init__.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| from hypothesis.extra.array_api import make_strategies_namespace | |||
|
|
|||
| from . import _array_module as xp | |||
| from ._array_module import mod as xp | |||
There was a problem hiding this comment.
This should only be the unstubbed module here, right? Maybe we should del xp so it isn't used elsewhere.
There was a problem hiding this comment.
I've aliased this to _xp now to avoid confusion with how we've aliased it everywhere else in the test suite. I could also just use mod blindly, but I think _xp is slightly better at indicating that this indeed is the array module.
|
I've asked Ralf to give you push access to this repo. You should probably still do PRs for now, but this will let you merge them once they are ready. This PR looks fine to me. Feel free to merge it once you resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
max_sizeis not its default value2, thenhh.mutually_promotable_dtypes()before returned undefined dtypes. This PR fixes that. Related to #33.I now bind
xpsto the underlying array modulemod, instead of the top-level stubbed one. Hypothesis gives nice errors when it encounters erroneous situations due to partial/incorrect Array API adoption, and like with the dtype strategies inhypothesis_helpers.pyit will work even if not all dtypes are available.I also add two test cases, one mocking an array module with undefined dtypes, and one actually testing an array module with undefined dtypes in
test_partial_adopters.py. Because of how the codebase is structured, it's pretty awkward to test partial adopters like I had done in Hypothesis, but a liberal use ofpytest.mark.skipif()allows us to test how our own strategies work with different array modules.