Do not require default dtype if no dtypes in kind supported #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of
__array_namespace_info__
'sdefault_dtypes
method requires that you return a default dtype for all the keys specified.The test suite here allows you to skip certain dtypes using the
ARRAY_API_TESTS_SKIP_DTYPES
environment variable. This means that it's possible to omit all the dtypes for a given kind. We use this in ndonnx to skip all complex dtypes since we're not able to support them at this time. In such a context, a default for"complex floating"
doesn't make much sense.I would like to only check the
default_dtypes
keys are present for kinds where we haven't skipped all the relevant dtypes. An alternative could be to make the value of the dictionary an optionaldtype | None
in a future version of the standard. I'd be happy with either option.