Skip test_matmul and test_remainder
#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just did a ndindex release that might have caused this. I'll have a look. |
|
Ah yes, this did break. I plan on fixing it in #101 but need to do some other fixes first. I can make a quicker workaround fix if it becomes an issue sooner. |
|
By the way the remainder thing is some bug on the CI platform. I have to skip all these tests on CI https://github.com/data-apis/array-api-compat/blob/main/numpy-skips.txt. Would be nice to figure out what's going on there but I don't think it's really worth the time (my guess is there's some bug in the cmath library used in GitHub Actions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both seem to fail the test suite sometimes, can look into later and leave skipped for now.