Use keyword-only arguments for the pytest helpers functions #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the inscrutable helper function calls more readable, and fixes at
least one instance where the arguments were called in the wrong order.
This also changes **kw to kw={} for the function keyword arguments, so there
is no ambiguity between function keyword arguments and arguments to the helper
function.
honno
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Thanks makes sense, I really should of done this in the first place—non-defaulted kw-only args have been an awesome revelation for me!
(Generally I'm not a fan of lines exceeding ~100 columns, but if we're not going to introducing a formatter than it's just bikeshedding to address.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the inscrutable helper function calls more readable, and fixes at least one instance where the arguments were called in the wrong order.
This also changes **kw to kw={} for the function keyword arguments, so there is no ambiguity between function keyword arguments and arguments to the helper function.
I've checked the codebase with pylint to make sure I didn't miss anything here, but if you know of any other tools that can check this we can run those as well.