Fix undefined dtypes being passed in kwargs of stat tests #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@asmeurer noted undefined dtypes could be passed as the dtype kwarg for
test_prod
, i.e. for pytorch (using data-apis/array-api-compat#14).This PR filters the pool of available dtypes so this doesn't happen for either
test_prod
ortest_sum
. Note these tests will still fail for pytorch as it doesn't follow the prod/sum-specific type promotion rules of the Array API.