Skip to content

Don't require can_cast to return False for cross-kind casting #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Don't require can_cast to return False for cross-kind casting #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion array_api_tests/test_data_type_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@ def test_can_cast(_from, to, data):
expected = from_min >= to_min and from_max <= to_max
else:
expected = False
assert out == expected, f"{out=}, but should be {expected} {f_func}"
if expected:
# cross-kind casting is not explicitly disallowed. We can only test
# the cases where it should return True. TODO: if expected=False,
# check that the array library actually allows such casts.
assert out == expected, f"{out=}, but should be {expected} {f_func}"


def make_dtype_id(dtype: DataType) -> str:
Expand Down