Skip to content

DOC: docs deployment failing #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucascolley opened this issue Apr 15, 2025 · 6 comments · Fixed by #273
Closed

DOC: docs deployment failing #266

lucascolley opened this issue Apr 15, 2025 · 6 comments · Fixed by #273
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@lucascolley
Copy link
Member

/usr/bin/git commit -m Deploying to gh-pages from @ data-apis/array-api-extra@6e3ad0f37d887f87d75de84e39148f50724a8c7a 🚀 --quiet --no-verify
Force-pushing changes...
/usr/bin/git push --force ***github.com/data-apis/array-api-extra.git github-pages-deploy-action/6tcgpwipr:gh-pages
remote: Permission to data-apis/array-api-extra.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/data-apis/array-api-extra.git/': The requested URL returned error: 403

https://github.com/data-apis/array-api-extra/actions/runs/14474620220/job/40597086566

@lucascolley lucascolley added this to the 0.7.2 milestone Apr 15, 2025
@lucascolley
Copy link
Member Author

Relevant section of workflow:

# Note, the gh-pages deployment requires setting up a SSH deploy key.
# See
# https://github.com/JamesIves/github-pages-deploy-action/tree/dev#using-an-ssh-deploy-key-
- name: Deploy
uses: JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8 # v4.7.3
with:
folder: docs/build/
ssh-key: ${{ secrets.DEPLOY_KEY }}

I don't have permissions to view the Deploy Keys or Secrets repo settings, but I would suspect something is up there if permission is being denied.

@lucascolley lucascolley added documentation Improvements or additions to documentation bug Something isn't working and removed bug Something isn't working labels Apr 16, 2025
@rgommers
Copy link
Member

secrets.DEPLOY_KEY does not seem to exist. gh-11 started using it, but no comments there and who made it. Do you remember? This looks pretty strange to me, keys usually don't just disappear.

@lucascolley
Copy link
Member Author

Hmm, that is strange. That PR was triggered by @asmeurer's suggestion at #3 (comment) — maybe you have an idea, Aaron?

@lucascolley
Copy link
Member Author

I also can't remember asking anyone to set it up. If my memory serves me well, I think I was actually surprised at the time that it worked out of the box. I think I assumed that it worked due to something at the organisation-level. (I might just be making this up retrospectively, it was a while ago)

@lucascolley

This comment has been minimized.

@lucascolley
Copy link
Member Author

AH: JamesIves/github-pages-deploy-action#1110 (comment)

We just need to adjust the workflow permissions. I can send a PR for that now.

The red herring was that the job doesn't fail unless you actually change the docs. We didn't change the docs for a while after changing workflow permissions for SPEC 8, so I didn't join the dots.

lucascolley added a commit to lucascolley/array-api-extra that referenced this issue Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants