-
Notifications
You must be signed in to change notification settings - Fork 34
ENH: speed up array_namespace
#329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if library == "ndonnx" and api_version in ("2021.12", "2022.12"): | ||
pytest.skip("Unsupported API version") | ||
if (library == "sparse" and api_version in ("2023.12", "2024.12")) or ( | ||
library == "jax.numpy" and api_version in ("2021.12", "2022.12", "2023.12") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this test requires jax>=0.6.1 to pass with api_version=2024.12. I didn't see much of a point adding special handling for older versions.
Could you please resolve the conflict |
@ev-br fixed |
Grumble grumble:
EDIT: sorry, no; my local Jax copy was too old. Nevermind. |
Thanks @crusaderky , merged. |
Related:
array_namespace
through caching scipy/scipy#23057Tested locally vs. jax==0.4.31.
Benchmark
Before
After
Note that the extra slowness of numpy is due to jax-ml/jax#20620